openvdb icon indicating copy to clipboard operation
openvdb copied to clipboard

Use Relative Paths in #includes

Open danrbailey opened this issue 5 years ago • 3 comments
trafficstars

Angle-bracket #includes like <openvdb/math/Math.h> run the risk of pulling in headers from nonlocal distributions, such as those installed by package managers. Use relative includes for cases where "../" is not introduced into the paths, such as openvdb/math/Finite.h using #include "Math.h" directly.

danrbailey avatar Jan 22 '20 23:01 danrbailey

hi @danrbailey i wan to work on it kindly elaborate

mridullpandey avatar Feb 25 '20 15:02 mridullpandey

@mridullpandey there's nothing really to be added here. All the bracket includes need to be substituted with relative version. @danrbailey would this include unittest directory as well?

kaarrot avatar Mar 11 '20 22:03 kaarrot

hi, @danrbailey Is anyone up to this issue? If not, I can work on this issue if that's okay?

rksharma95 avatar Jan 13 '22 03:01 rksharma95

This issue should have been resolved with #1418.

gaida-exe avatar Oct 13 '22 06:10 gaida-exe