Gadi Cohen

Results 636 comments of Gadi Cohen

@mtorregrosa, big thanks again for all this back and forth. Really appreciate it. > The problem is with the field **date**, that should be of type **Date**, in accordance with...

Thank you so much, @mtorregrosa! Appreciate all the help. :pray:

Ooh, thanks, @Yhprum... somehow I missed the `options` module when I fixed the missing exports everywhere else (I hope! :sweat_smile:). This is fixed now and will be in the next...

@mtorregrosa: > I've just discovered another runtime issue that seems to be related with type validation of the response for request > > `yahooFinance.quote(symbols, { fields: ['regularMarketPrice'] })` Thanks for...

Gotcha; thanks, @mtorregrosa :pray: Glad you have a temporary work around so I have a bit more time to handle this properly. Have a great weekend!

Hey @eddie-atkinson, moving the typebox part of our chat from #826 to here: As you say, there were a few small things that were easily fixed. And the DX is...

@eddie-atkinson, following on from last comment last year and re the above commit: With great regret, I decided to move back to the old approach. I definitely think that at...

Hey again @eddie-atkinson Greatly appreciate your understanding on this... it wasn't a decision taken lightly. And sure, my pleasure re the validation - the least I could do, honestly. Thanks...

Ah, it's because we dropped Node 18 support and it seems I forgot to update the README. We usually cover the full maintenance cycles of node releases too but there...