Gadi Cohen

Another small issue with the conversion that I found, for adjClose, because: 1. In `historical()` it's adjClose 2. In `chart()` it's adjclose We don't currently handle this correctly, I need...

Above fixed / released in 2.12.14 :tada:

Hey @mikhail, interesting find. On face value all I can say here is that I guess jest is doing something to `fetch` that is affecting things. Could I also trouble...

Hey, thanks for the quick reply. Let me know your setup and the exact error, when you have a chance. I just need to forewarn that I'm currently abroad with...

In case it's related, there was an issue affecting some bundlers, like webpack/nextjs, that was just fixed in https://github.com/gadicc/node-yahoo-finance2/issues/928. But still not sure exactly which error you got.

Thanks, @mikhail. Can you just confirm your environment and node version, and if you saw [UPGRADING.md](https://github.com/gadicc/node-yahoo-finance2/blob/devel/docs/UPGRADING.md)? The rest of the docs aren't updated yet.

Hey @mikhail Thanks for reporting back, and for posting your findings and workaround. I wonder where the actual problem is though, it seems like `jest` is doing something to `fetch`?...

A few further clarifications... The `global.fetch = undiciFetch` has to happen before calling `new YahooFinance()`, because we store a ref to it, i.e. ```ts const YahooFinance = require("yahoo-finance2").default; const undiciFetch...

Yeah, also didn't find anything on a quick search :/ Since the new 3.6.0 published now, we at least don't store a ref anymore by default, which makes things easier...

I wonder if we could still support older versions with something like: ```diff - const currentMetaMaximized = metaWindow.get_maximized(); + const currentMetaMaximized = (metaWindow.get_maximized || metaWindow.is_maximized)(); ```