Gadi Cohen

Results 637 comments of Gadi Cohen

Hey, thanks so much, @Emre4x0, appreciate your super quick response and kind words. I'll leave this open so we can still track it. I'd also like to cleanup the error...

Thanks, we were tracking this at https://github.com/gadicc/node-yahoo-finance2/issues/349#issuecomment-2335142620 but going to move here to make this easier to find (as a recent issue). My original response: Mmm, on the Yahoo page...

Hey all, just a big thanks from me to everyone above, for sharing all your findings, and most especially, your solutions and their verification, which is a great help to...

Thanks, everyone. Finally had a chance to work on this. As discussed, it's simply a convenience to map the requests to `chart()` for you... you'd be better using `chart()` directly....

:tada: This issue has been resolved in version 2.12.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/yahoo-finance2/v/2.12.0) - [GitHub release](https://github.com/gadicc/node-yahoo-finance2/releases/tag/v2.12.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

Resolved but leaving this issue open for feedback and discoverability.

Oops, now I'm seeing some of those null errors that @stouch mentioned :sweat_smile: That fix will come next :sweat_smile::sweat_smile: e.g. `yahoo-finance historical 0P0000XTS7 '{"period1":"2024-09-12"}'`

Above issue fixed in 2.12.1. I re-used the [old row null logic](https://github.com/gadicc/node-yahoo-finance2/commit/63c449894e50a2803ef40dd0bd100f1fbb6965cc#diff-7c6bf8a8bd3336b085e4fe22f1b143d0d371885803cbce8a3361723191fc2f58R241-R261) from before (and as described in [docs/historical.md#null-rows](https://github.com/gadicc/node-yahoo-finance2/blob/devel/docs/modules/historical.md#null-rows)), which skips when entries when everything is null, but throws otherwise...

@mtorregrosa, right you are, this was a mistake on our side when we changed over to the new type system. Hopefully fixed in **2.12.2**, can you confirm? And everyone, one...

Thanks, @mtorregrosa, this is really helpful. Our apologies again for the hassle and our thanks for taking the time to report and for your patience. I'm moving the type issues...