Gabi Melman comments

Results 158 comments of


                                            Gabi Melman

#3399 broke compatibility with all versions of libfmt prior to 11.2.0

> Yeah, google shows it being present in GCC docs at least as far back as 2012. But msvc doesn't offer this in earlier version afaik. Lets try to ask...

Error: ‘fmt::v11::detail::type_is_unformattable_for<XTP_POSITION_DIRECTION_TYPE, char> _’ has incomplete type when using spdlog headers

Please provide code to reproduce and compiler info

How do I log a std::iostream?

An elegant way would be to define custom type that accepts std::iostream, using https://fmt.dev/latest/api/#formatting-user-defined-types And then one can just pass the stream to spdlog: ```c++ spdlog::info("Stream content is: {}", content_stream);...

#define SPDLOG_LEVEL_NAMES with external FMT doesn't compile, starting from libfmt11.

PR is welcome. Note that the “sv” literal is c++17 while spdlog should support 11

after_open file-event handler firing twice for some reason?

Note you construct the file sink with rotate_on_open=true which might lead to this behavior

Fix extra carriage returns in piped ANSI output on Windows

The ansicolor sink was never designed for windows. Why not use the wincolor sink

Clear previous background color for win32 console before setting new one

Could you please provide more details why is it needed ? so far it worked fine

file_helper support mmap

Thanks. Do you have any numbers on the improvement gains?