Gabi Melman

Results 158 comments of Gabi Melman

closed. i dont want to add new features to this stable branch

Problem is that it converts to wstr (utf8_to_wstrbuf) and would affect existing code and performance which doesn't need wstring output to console. Please provide a way to use it only...

Yes, please surround with different macro, something like `SPDLOG_UTF8_TO_WCHAR_CONSOLE` That being said, if this is a common issue, we should consider adding a `console->enable_utf_to_wstr(bool)` to the api instead.

spdlog async is much slower than synchronous spdlog. It is interesting to compare to the synchronous version of spdlog.

I strongly recommend using spdlog as complied lib instead of using the header only version. This reduces significantly build times of modules that include spdlog

@pramodk See https://github.com/gabime/spdlog/blob/v1.x/example/CMakeLists.txt on how to use the compiled version with cmake.

> Is there a way to log from spdlog without creating any additional worker threads Yes, Don’t use async logger. If you must use async logger, it is worth trying...

I agree. PR is welcome