Gabi Melman comments

Results 158 comments of


                                            Gabi Melman

Extra attributes for log_msg

@bachittle Thanks for the effort anyway. The new mdc impl was chosen because it is super simple and doesnt require any breaking changes.

CMake: Build directory `spdlogConfigTargets.cmake` doesn't provide a `spdlog::spdlog_header_only` target

@robertmaynard Thanks for reporting. PR to fix this would be most welcome.

CMake: Build directory `spdlogConfigTargets.cmake` doesn't provide a `spdlog::spdlog_header_only` target

@robertmaynard Any chance you send PR for this before next release (few days)?

Wrong order of logs within `QTextEdit` in qt5

Re-added qt_color_sink after fixing threading issues.

2.x branch: Some commit after 287d83 broke include directory install

Do you mean after “make install” ?

inline registry leads to split instances across .so borders

fwiw we are thinking about ways to improve this in v2.x branch. Perhaps by adding a function to set/get the registry instance, so that dlls can be provided a registry...

[Possible Bug] : undesired deletion of logger from registry(loggers_ map)

I agree. Seems undesirable.Maybe the fix would be just set the `default_logger_` without touching the loggers_ at all. I can’t recall though why it was implemented like this.

Not able to save logs with rotating_file_sink_mt

All log to the same file?

Hide non-API functions

Thanks. Why only in PIC ? I think it can be used without pic as well.

We need to be careful since the bundled fmt use [default](https://github.com/fmtlib/fmt/blob/130cf54cbc77abf0c8200a1206638cb70c9e26f1/include/fmt/core.h#L201) visibilty. Not sure what would happen. i.e. If users of spdlog will be able to use the bundled fmt...