Franco Victorio comments

Results 565 comments of


                                            Franco Victorio

pending tests

Hi, I'd like to help with the tests for the indentation rules, if no one is already working on that. I'm just getting familiar with the codebase, but this seems...

pending tests

Cool! Mark it as `In Progress` if you want, I'll start working on it.

cli input from stdin will fail in windows environment

This is how ESLint does it: https://github.com/eslint/eslint/blob/6791d189da84bd1a06b326e645f021e4a74bd2e0/bin/eslint.js#L59-L75 It's styll async, but they do it before calling the main `execute` method. Maybe something like that could be done in `bin/solium.js`?

Contract revert reasons can mimic node errors

I think this is working correctly when the gas is estimated, but the same problem shows up if you set a specific gas limit in the overrides :cry:

Contract revert reasons can mimic node errors

It happens when using Hardhat's node, but it does not happen with `geth --dev`. I don't know why. One difference I noticed is that, when using geth, I have to...

Failed view function calls with empty return data don't throw an error

Thanks! > A `staticCall` should not use gas estimation, but I'll double check. :) Oh, sorry, I meant in the case that the `estimateGas` calls also used the return data...

Support for nested loadFixture()

Thanks for this @m1cm1c, but I think it's better to just document this behavior better, as discussed in #2980.

unintelligible error: Internal exception in StandardCompiler::compile:

This seems like a `solc` problem. @cameel do you recognize this problem?

unintelligible error: Internal exception in StandardCompiler::compile:

I'm closing this since it's not related to Hardhat. Thanks a lot @cameel for chiming in!

Allow custome maxPriorityFeePerGas in hardhat.config.js (@hardhat/ethers)

Hi @Amxx, thanks for opening this. This would be an interesting feature, but I'm not quite sure about the implementation. Is `getFeeData` *meant* to be be overridden? Or would it...