Ethlint icon indicating copy to clipboard operation
Ethlint copied to clipboard

pending tests

Open duaraghav8 opened this issue 8 years ago • 4 comments

Need to write tests for:

  • [ ] function-order rule's ignore options
  • [x] Indentation rule(s) - https://github.com/duaraghav8/Solium/commit/00bc6d2ed87af7c924e809deff55320f71d2fd61
  • [x] Autofix API & mechanism
  • [x] everything in #97
  • [ ] Messages supplied by exceptions
  • [ ] Tests for rules of the security plugin https://github.com/duaraghav8/solium-plugin-security
  • [x] Test for all rules that work with line breaks (blank-lines, indentation, whitespace, etc) - need to test that they work as expected on linux, mac & windows (different platforms have different newline encoding)

duaraghav8 avatar Aug 11 '17 03:08 duaraghav8

Hi, I'd like to help with the tests for the indentation rules, if no one is already working on that. I'm just getting familiar with the codebase, but this seems approachable to me.

Do you manage issues assignments in some way to avoid work duplication? Or is this comment enough to let others know?

fvictorio avatar Oct 14 '17 12:10 fvictorio

@fvictorio nobody is currently working on it and you're free to take this up. If you do, just let me know and I'll add the In Progress tag to this issue. Thanks for your contributions! You can always DM me on our Gitter Channel or email me in case you have any doubts or suggestions.

duaraghav8 avatar Oct 14 '17 14:10 duaraghav8

Cool! Mark it as In Progress if you want, I'll start working on it.

fvictorio avatar Oct 16 '17 21:10 fvictorio

Indentation: add test for #268 too

duaraghav8 avatar Jul 01 '19 10:07 duaraghav8