Tomoya Fujita

Results 1299 comments of Tomoya Fujita

@amalnanavati > But as far as I can tell, it doesn’t change the name that a service/client created by node.create_service and node.create_client actually listens on. Can you elaborate what this...

@amalnanavati no worries, it is always nice to check. thanks for the reply!

https://github.com/ros2/rclpy/pull/1156 is merged, i will go ahead to close this.

@apockill could you address DCO issue? i will review this tomorrow.

CI: * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16236)](http://ci.ros2.org/job/ci_linux/16236/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=10861)](http://ci.ros2.org/job/ci_linux-aarch64/10861/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=16592)](http://ci.ros2.org/job/ci_windows/16592/)

@apockill could you check on https://github.com/ros2/rclpy/pull/899/checks?check_run_id=5307997326 ?

CI: * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=16308)](http://ci.ros2.org/job/ci_linux/16308/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=10928)](http://ci.ros2.org/job/ci_linux-aarch64/10928/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=16678)](http://ci.ros2.org/job/ci_windows/16678/)

@apockill can you rebase this fix? i believe a couple of CI failure is related to https://github.com/ros2/rclpy/commit/8c4892b3ccbbaec23f88cc4c8d10e5fc1f3ade91. I want to be sure on this, so after rebase I will restart...

@apockill we are having DCO error https://github.com/ros2/rclpy/pull/899/checks?check_run_id=5576899504, can you check?