Tomoya Fujita

Results 1293 comments of Tomoya Fujita

I am not original author on this code, but It seems to return TypeError explicitly and intentionally. So i just would like to hear from other opinion.

@mr337 thanks for the issue, i confirmed that this problem is not only for foxy but mainline source build with https://github.com/ros2/ros2/commit/5a35507c37f3b0449e31cb4073cf0352bfd52b0b. - SingleThreadedExecutor ```bash # ros2 run prover_rclpy rclpy_983 Traceback...

with https://github.com/ros2/rclpy/pull/984, `MultiThreadedExecutor` can raise the user exception like `SingleThreadedExecutor`. ```bash # ros2 run prover_rclpy rclpy_983 Traceback (most recent call last): File "/root/ros2_ws/colcon_ws/install/prover_rclpy/lib/prover_rclpy/rclpy_983", line 33, in sys.exit(load_entry_point('prover-rclpy', 'console_scripts', 'rclpy_983')()) File...

I need to reopen this because of https://github.com/ros2/rclpy/pull/1017

@mr337 PR would be really appreciated. Implementation Note: It should not submit the execution, cz it will block the `submit` method until the future is completed. This is because https://github.com/ros2/rclpy/issues/1016...

> do you think this issue is still valid? yes, i think this is a bug. uncaught exception should be raised to user application from executor. as i mentioned https://github.com/ros2/rclpy/issues/983#issuecomment-1271782711,...

@Achllle thank you for the contribution, everything has been done including backport humble.

> @fujitatomoya Since Foxy is still actively supported for another month, could we consider backporting that distribution too? :+1: so that it will be available for last patch. > That's...

@tsender @Achllle foxy backport, https://github.com/ros2/rclpy/pull/1116 if you would verify and review, that would be appreciated!