Tomoya Fujita

Results 1232 comments of Tomoya Fujita
trafficstars

@MiguelCompany i say we should especially for jazzy and humble, but this is breaking ABI change?

@MiguelCompany i am okay with backport for jazzy, lets hear from other opinion.

@clalancette what do you think about backporting jazzy? IMO, this should be no problem and better bug fix for jazzy LTS.

@mxgrey i may be mistaken something, but here are my comments. are you suggesting we should remove `allow_undeclared_parameters` flag and `rclcpp::exceptions::ParameterNotDeclaredException` at all? either `allow_undeclared_parameters` is true or false, we...

> To make this discussion easier, I've gone ahead and implemented the changes I recommend in a draft PR #2515 thanks, i will take a look! > The error message...

@mxgrey thank you very much iterating and sharing thoughts, i was checking myself what could be missing here. but now it is clear to me! > Consider a node that...

@mxgrey i added this to Client WG meeting. hopefully we can get some feedback from there.

I am not sure if this is fixed with specific PR, but this problem cannot be observed with `rolling`.

@adamlm thanks for checking this! actually what i tried is to source build with `rolling`. so maybe latest patches in rolling source (not available as package) fix this issue.

Pulls: ros2/launch#827 Gist: https://gist.githubusercontent.com/fujitatomoya/888efa6fa066afcfe2125fb80df6160b/raw/6e7731e24d3b58d95e26a484450d1f98040492c6/ros2.repos BUILD args: --packages-above-and-dependencies launch TEST args: --packages-above launch ROS Distro: humble Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15140 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=22473)](http://ci.ros2.org/job/ci_linux/22473/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=16725)](http://ci.ros2.org/job/ci_linux-aarch64/16725/) * Linux-rhel...