Tomoya Fujita

Results 1216 comments of Tomoya Fujita
trafficstars

> rclcpp::Logger is declared as const and adding a state (a boolean to disable the log) to this would change the const correctness. i think we can change this if...

@deepak-anzo can you go through https://docs.ros.org/en/humble/Installation/DDS-Implementations/Working-with-Eclipse-CycloneDDS.html? i think you are just missing the cyclone dds package.

@CursedRock17 thanks for the PR, i will take a look. in the meantime, can you address DCO error? https://github.com/ros2/rclcpp/pull/2188/checks?check_run_id=13298073729

@CursedRock17 thanks for iterating and being responsive. i will take a look tomorrow, in the meantime can you address DCO error?

> Docker for Ubuntu 22.04 correct? yes, as long as the userland is Ubuntu 22.04, i believe there should be no problem for this PR verification.

@smnogar would you address comments above? thanks!

@threeal this's been 3 years. still working on this? if you are, could you please rebase this?

@InvincibleRMC 1st of all, really appreciate all the contribution you have been and are making for `rclpy` type check. we expected that this feature request would come up. i think...

@clalancette that is true, i did check some of the `broken` lines to make sure if linkcheck reports the actual broken URLs. some of them are totally no problem, as...

CI: * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=20681)](http://ci.ros2.org/job/ci_linux/20681/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=15002)](http://ci.ros2.org/job/ci_linux-aarch64/15002/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=21377)](http://ci.ros2.org/job/ci_windows/21377/)