rclcpp
rclcpp copied to clipboard
ros2
Exposed rcl_actions to the NodeGraph class
This pull request is meant to address issue #1473 which needs rcl_action functions exposed to the NodeGraph class. As mentioned:
- rcl_action_get_client_names_and_types_by_node
- rcl_action_get_server_names_and_types_by_node
- rcl_action_get_names_and_types
were all meant to be exposed from rcl to rclcpp, which based on the previous comment meant to make methods similar to rclpy. So each of the functions developed in this PR all follow a similar format of gaining access to the original rcl_action methods with a rcl_ret_t type and return a map of all the names and types.
@CursedRock17 thanks for the PR, i will take a look. in the meantime, can you address DCO error? https://github.com/ros2/rclcpp/pull/2188/checks?check_run_id=13298073729
in addition to comments, it would be ideal to add the test cases to
rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpp.
The most recent commit I pushed contained the tests for the rcl_action_get_names_and_types I followed format for other similar methods in the file. Was that the way that made testing the most efficient for those types of functions, if so, I can replicate with so more tests for the other new functions.
@CursedRock17 thanks for iterating and being responsive. i will take a look tomorrow, in the meantime can you address DCO error?
@CursedRock17 can you check building and testing with your local environment? i cannot build or test this PR... thanks in advance.
Yes I can test, I can do it on both my computer and Docker for Ubuntu 22.04 correct?
Docker for Ubuntu 22.04 correct?
yes, as long as the userland is Ubuntu 22.04, i believe there should be no problem for this PR verification.