fuhlig

Results 20 comments of fuhlig

Also experiencing `needless-disables` for `declaration-block-no-duplicate-properties` and `scss/no-duplicate-dollar-variables` ```scss .selector { width: 100%; width: calc(100% - #{($sass-var * 2)}); /* stylelint-disable-line declaration-block-no-duplicate-properties */ } ```

> I'd suggest that it is not added to backstop executable per se. I think it could very easily be implemented as a node script which rewrites the report JSON...

Just brainstorming here, without knowing the current internals... If the option is passed in, only the scalenarios containing a diff get picked up by the report. Passed scenarios are not...

> @fuhlig Where do you see the entry point for this as a built-in feature? How would you manage the extra/alternate assets? What do you refer to by _extra/alternate assets_?

Could be caused by stylesheets not being processed when screenshot is taken. Consider using `readySelector` or `delay` https://github.com/garris/BackstopJS#advanced-scenarios

While you're at it - consider renaming `master` branch to a more inclusive name (`main`)

If I understand you correctly, you want to compare the screen design (artboard, screendesign) from Zeplin with your implementation? Eventhough this might be possible (comparing 2 images basically) I highly...

Had the same when running backstop with puppeteer & chrome in CI (linux) environment. https://github.com/puppeteer/puppeteer/issues/3504 This fixed it for us (conditionally for CI env): ``` // backstop.config engineOptions: { executablePath:...

Any progress on this? :)

similar for regression testing: when testing components for visual regression, only the first found selector is compared to previous reference. it would be great to compare all found selectors to...