Fabian Stäber

Results 301 comments of Fabian Stäber
trafficstars

TestContainers use Docker to run tests against Docker containers. In order to make them work with CircleCI, we need to switch to machine images: https://github.com/prometheus/client_java/blob/103eb5961d765b64ce145a50f9e24b84d5d61a21/.circleci/config.yml#L1-L18 Not sure if we can...

I like the idea to have a clear definition which Java versions can be used to build `client_java`, and I think it's a great idea to have automated tests for...

I am hoping to get the OpenTelemetry exemplars branch done this week. I'll try the `setup_remote_docker` then.

Note: `client_java` now has a Jetty Jakarta Servlet example (https://github.com/prometheus/client_java/blob/master/simpleclient_servlet_jakarta/src/test/java/io/prometheus/client/exporter/ExampleBenchmark.java) which requires Java 11 to build.

Regarding the specific case of `null` values: If we revisit this and _not_ throw an `IllegalArgumentException`, what do you think would be a good default value? The literal string `"null"`...

> especially when the number of label combinations is high I think this is the real issue here. You should attempt to reduce the label combinations to a reasonable number...

Thanks! This would be for rel 1.0.0, so I'll put this on hold until we have the rel 1.0.0 branch.

Thanks for the PR. It would be useful to produce the same format as `TextFormat.writeOpenMetrics100()`, so that the `toString()` representation doesn't differ from the OpenMetrics format. What do you think?

Thanks for the feature request. I will get back to this as soon as the Exemplars feature is done.

Hello again, I had another look. * Regarding javadoc: The directory with the source code is literally called `micrometer.tracing` and not `micrometer/tracing`. * Regarding static initialization: Is there any chance...