Fabian Stäber
Fabian Stäber
The default implementation first collects all metrics, and then applies the filter. So if the `NullPointerException` happens during metric collection the default implementation will not work. What you need is...
I was thinking you add a method like this to `DropwizardExports`: ```java @Override public List collect(Predicate nameFilter) { // TODO: Collect only metrics where nameFilter.test(name) is true } ``` With...
I don't think it's a good idea to have an "implicitly ignore all erroneous metrics" option. It would be better to ignore them explicitly. If the `NullPointerException` does not provide...
Not sure if I understand this correctly: You want to write a Java library, and this library should provide Prometheus metrics. You are looking for a way that an application...
Ah, I see what you mean now. It's hard to say how difficult it would be to implement a `match[]` parameter, because that means we would need to re-implement the...
Yes, I think you found the root cause. Just curious: How are you running Micrometer with the Prometheus `client_java` 0.10.0? The latest Micrometer version 1.6.4 is bundled with the Prometheus...
Hi anilkonduru, I need some more information to answer this. How do you create the `counter`, and how do you expose the Prometheus metrics?
Looks like the Graphite Tag Support was added with Graphite release 1.1.X (end of 2017) while the `simpleclient_graphite_bridge` was implemented beginning of 2016. So no wonder that this is missing....
``` module test.prometheus reads package io.prometheus.client from both simpleclient and simpleclient.servlet ``` I'm not familiar with the Java module system, but reading this message I'm wondering: Is it really necessary...
Hi thanks a lot for your PRs. I saw them, and I will get back to this as soon as I found time to test this with different Java versions...