Fabian Stäber

Results 301 comments of Fabian Stäber
trafficstars

@tjiuming I am struggling to understand what the feature is about. The description is just a reference to #782, so is this about a performance improvement?

Hi, first of all, thanks a lot for the discussion, I really appreciate everyone is taking the time to look into this and to find a good solution. Few remarks...

Proposal: Compatibility with Jigsaw (Java module system). Currently multiple Maven artifacts expose the same Java package, which makes it impossible to use them as modules in the Java module system....

Proposal: Renaming the default exports. Some of the default exports from `simpleclient_hotspot` don't follow the OpenMetrics naming conventions, and some of the metric names are inconsistent (use of the `jvm_`...

Not sure about this one, but I feel some Maven modules could have more descriptive names: * `simpleclient_common` -> `prometheus_textformat`? * `simpleclient` -> `prometheus_metrics`? * Rename `simpleclient` to `prometheus` everywhere?...

I didn't take a deeper look into Java modules yet, but my understanding is that a Java module is just a regular JAR file that contains an additional module descriptor...

@matthiasr these are great questions. > What makes 1.0.0 more suited for breaking changes than an 0.x.0 release? The last release with significant breaking changes was 0.10.0, when we switched...

Keep up with new JVM features * Get data for default exports from JFR events instead of JMX beans * Use the JEP 408 simple web server instead of com.sun.net.HttpServer...

Thanks a lot, that totally makes sense. Would you like to open a PR for `client_java`?

FYI: I added TestContainers as part of my OpenTelemetry exemplars branch to test compatibility with different Java versions (including Java 6, which causes the most problems): https://github.com/prometheus/client_java/blob/103eb5961d765b64ce145a50f9e24b84d5d61a21/integration_tests/java_versions/src/test/java/io/prometheus/smoketest/JavaVersionsIT.java#L35-L43 It's not merged...