Howard Liu

Results 43 comments of Howard Liu

@tenebrius1 1. As far as I know we are quite loose about npm dependencies since they are used frontend and do not impose much security issue to the production data....

@u6867511 I don't think so. You are good to submit a PR for this.

@samuelfangjw @jianhandev @NicolasCwy @wkurniawan07 Any of you are available for a final review of this PR?

@NicolasCwy @jianhandev @wkurniawan07 A final review for this PR is appreciated. @thikhinab Please mark the above review as "resolved" after you have fixed them.

@thikhinab Reminder for this PR again. Jianhan has provided you feedback. Just a little bit more to fix and it will be good to merge.

@zhaojj2209 @samuelfangjw Would appreciate if any of you can do a final review.

I can confirm this happens on Android device (Firefox browser). Probably the existence of status bar above leads to a wrong calculated y-position?