Howard Liu comments

Results 43 comments of


                                            Howard Liu

[#11947] Improve UI of Error Toasts

@thikhinab Could you run a local check and see if it fails or not?

[#11639] Create DateTime service and replace time-related magic numbers

@samuelfangjw @ziqing26 @zhaojj2209 Any review for this PR would be appreciated.

[#11878] Account Request Form Upgrade - Backend

@fans2619 Reminder for this PR.

Add unit tests for `SubmitFeedbackResponsesAction`

@Serafion We do not add backend dependencies unless it is really essential. If typicalDataBundle solves the problem, please go ahead with it.

[#11564] Linting should be skipped for generated files during local build and test

@tenebrius1 I think either one is fine. Regarding your concerns: 1. Yes. It would be better if cross-platform can be achieved and no external programs are added as dependency (e.g....

[#11564] Linting should be skipped for generated files during local build and test

Sure. So no pre-commit hooks now and it still lints the diff. This still fix the problem described in the issue.

[#11564] Linting should be skipped for generated files during local build and test

I am fine with the changes. A second review is requested. @NicolasCwy @samuelfangjw @sivayogasubramanian

User documentation: don't use bold to refer to UI text

@prafullpandey614 Hi thanks for your will to contribute. However, there is already an opened PR (#11954) associated with this issue. It will be entering review phases. You may work on...

Instructor/admin search/help page: Search text is highlighted yellow in V6 but not in V7

@tau-bar Sure. Please go ahead.

Linting should be skipped for generated files during local build and test

@tenebrius1 I don't think anyone is doing that. Please proceed.