Fabian Ruffy
Fabian Ruffy
> > One problem is the amount of warnings being thrown: > > Most of the warning seem to come from base class virtual methods that have unused arguments --...
> That code is all generated by the python code in bf-asm/walle/csr.py -- I'll try to take a look at it this weekend. Currently disable these warnings using `-Wno-unused-parameter -Wno-unused-variable...
@ChrisDodd If you have some time, could you give the last couple commits a review? I tried to fix some warnings but some of the changes I am not 100%...
> It would be good to have some automated tests (in CI?) that ran the tofino backend compiler and assembler. We do have around 50 tests for TNA and T2NA...
Merging this one. The other issues I can try to resolve in subsequent PRs.
> Note that `btree_map` has different iterator invalidation rules as compared to `std::map`. Not sure if it matters, but worth double checking. We do not remove elements from these maps...
I noticed `solver.h` depends on `IR::SymbolicVariable`, which is only defined in the p4tools back end. Either we move the definitions of these files to the top-level def files, or move...
Ideally, this should be an assertion in the tests frameworks. Anywhere where we import ptf we should check that the version is recent.
The MacOS failure is unrelated and fixed by #4976.
You also need to sign DCO, please see instructions here: https://github.com/p4lang/p4c/blob/c05b04c3785059b1bf4faa2354377f0f47fb7950/CONTRIBUTING.md#contributing-license