Fabian Ruffy
Fabian Ruffy
The other failures is caused by this line https://github.com/p4lang/p4c/blob/c67d1fd01f598ccf9ee9ec115d5901ac799f97be/backends/p4tools/modules/testgen/targets/tofino/test/p4-programs/tna_simple_switch.p4#L33 This is also not a supported option for P4Testgen but the pragma is still parsed as input.
I see three possible ways to solve this: 1) Since options may depend on the compiler executing the program, maybe extend this pragma with a "target"/"arch" field to ensure the...
> This line was not touched by this change, so there's no change here It's existing code that had no impact but is now active because of https://github.com/p4lang/p4c/pull/5053/files#diff-b033ed467d2767be363300d09ff13ac0a990d2e0de7464b732d9b29888da81a1R54.
Will be able to review the `action_run` pass later this week. But I'd suggest to split out the changes to `P4COptionPragmaParser` into a PR we can discuss separately. I think...
Could you remove the code that is related to #5123. Or do you want to rebase it on top of that PR? Would be good to get a review from...
> It requires that PR (for the testcase included here), and is (re)based on that. Ideally, that one will be approved (and merge first), then this one will rebase and...
I am also running into this problem when using dotfiles. The reason is that the dotfiles are slightly out of date and force overrwriting would fix it. Fixing it requires...
> @fruffy any suggestions you would like to give > > > I will give this a thorough look later. run-xyz you do not need to map. You do not...
> @fruffy ya sure I will update the video but I thing i would like to suggest is that we should mention somewhere that one can use [bug] like this...
> Hey @fruffy can you please tell if you want this auto labelling feature on pr also so that I can modify the code a little bit Yeah for PRs...