Prevent compiling backend tests if dependencies are not installed

Open ParthShitole opened this issue 1 year ago • 5 comments

The added code checks for required dependencies before adding tests.
This makes sures the Test don't fail due to missing dependencies.

solves #4535

Oct 22 '24 15:10 ParthShitole

@fruffy I have modified the CMakeLists.txt file for ebpf backend to check for dependencies. If the dependencies are missing the tests are not added and appropriate message is printed. I request you to review it once. if it looks good to you, I will add these changes for other backends as well.

Oct 22 '24 15:10 ParthShitole

The MacOS failure is unrelated and fixed by #4976.

Oct 23 '24 12:10 fruffy

You also need to sign DCO, please see instructions here: https://github.com/p4lang/p4c/blob/c05b04c3785059b1bf4faa2354377f0f47fb7950/CONTRIBUTING.md#contributing-license

Oct 23 '24 16:10 fruffy

@fruffy I have made the requested changes. Can you review it again.

Nov 19 '24 12:11 ParthShitole

@fruffy I have made the requested changes. Can you review it again.

Let me take a look later this week.

Nov 19 '24 16:11 fruffy