Israel Fruchter
Israel Fruchter
> > I'd leave pylint comments to minimize the change. Removing them is similar to reformat which we wanted to avoid. > > I proposed to leave only first commit...
> > > > I'd leave pylint comments to minimize the change. Removing them is similar to reformat which we wanted to avoid. > > > > > > >...
> > If you are gonna read it all line by line, every signal change here. I'll just merge it now and that's it. > > that's not the point...
> are there kafka metrics worth to add to monitoring? If yes, can be done in followup task. this one is a local setup of kafka, I don't think monitoring...
> > > are there kafka metrics worth to add to monitoring? If yes, can be done in followup task. > > > > > > this one is a...
So the longevity code we have basically works But it hangs cause we don't have code to stop the Kafka reading thread, might use the idea of teardown validator to...
> > So the longevity code we have basically works > > > > But it hangs cause we don't have code to stop the Kafka reading thread, might use...
Two Jobs introduced are passing now One small pre-commit issue, and it's good to go
@Bouncheck I would recommend you try it again, to get familiar with it.
@aleksbykov @temichus can you please attend to this one, I don't know what the calculation should be there, but seems like it's wrong (or doesn't fit all cases)