Israel Fruchter

Results 1006 comments of Israel Fruchter

@qiuqiu-007 ``` 2023-12-13T01:19:33.687533571Z WARN 2023-12-13 01:19:33,684 seastar - Requested AIO slots too large, please increase request capacity in /proc/sys/fs/aio-max-nr. available:65536 requested:102052 2023-12-13T01:19:33.687550162Z WARN 2023-12-13 01:19:33,684 seastar - max-networking-io-control-blocks adjusted from...

> @fruch I tried, but it doesn't work. [log2.txt](https://github.com/scylladb/gemini/files/13659240/log2.txt) forgot the actual update, that would get it updated: ``` sysctl -p ```

Two things, this change might break users code, since it's returning a different type than it used to. Duck typing and all, people that have code doing things based on...

> @sylwiaszunejko thanks for owning this. > I think that @fruch suggestion to suggest it to the upstream and get their feedback is a good start. > > When we...

> > > @sylwiaszunejko thanks for owning this. > > > I think that @fruch suggestion to suggest it to the upstream and get their feedback is a good start....

> @avelanarius @fruch @nyh @Lorak-mmk What should be my next steps? How should I contact upstream Raise an issue, and open a PR similar to this one. it might take...

@k0machi but what is the exact breakage you referring to ?, and which version of the driver was inflected with it ? (maybe it's was fixed here already..)

> Interesting, I remember that I did try to do this at one point, but got a lot of failures. Maybe I just made some mistake when running the tests....

> I think we can merge it after CI passes one of the integration suite was stuck for 5h, I'm running it all again: ``` tests/integration/standard/test_metadata.py ss...s.............x...s.s.. [ 15%] s...s.ss.s...x.s.x.....sssssssssss...ss.s....s.s...ss...