Israel Fruchter comments

Results 1041 comments of


                                            Israel Fruchter

When the fast way to validate that service level is propagated to all nodes will be developed, we need to use it in `sdcm.sla.libs.sla_utils.SlaUtils.wait_for_service_level_propagated`

> @fruch > I opened it here to be on top of it and change the code is they will provide it such ability If so edit the title and...

Low performance when installing from repo file (requires restart)

isn't that an issue with scylla ?, i.e. that installation of the box behave better after restart ?

Low performance when installing from repo file (requires restart)

> I don't know, I need to reexamine what happens when we install from repo file - if we do proper restarts after io-tune and if our procedure adhere from...

Low performance when installing from repo file (requires restart)

@soyacz do we have anything else todo with this one ?

feature(pre-commit): replace pylint with ruff

@roydahan @soyacz @vponomaryov @juliayakovlev @k0machi since this gonna affect the daily work of all of us, it would help if you can take it for a walk, and see how...

feature(pre-commit): replace pylint with ruff

> @fruch I think we should skip rules making us replace `single-quote` with `double quote` symbols and `adding trailing comma`. > Why? Because it is all over our codebase. >...

feature(pre-commit): replace pylint with ruff

> > @fruch I think we should skip rules making us replace `single-quote` with `double quote` symbols and `adding trailing comma`. > > I'm opting also to skip this -...

feature(pre-commit): replace pylint with ruff

@soyacz @vponomaryov I've remove the `double quote`and `trailing comma`, but still the list of change is quite huge. I think it's acceptable, and a one off that would happen on...

feature(pre-commit): replace pylint with ruff

> @fruch > Added more comments after looking at several python files. > There are a lot of cases where transformation is ugly because the structure doesn't get changed. >...

feature(pre-commit): replace pylint with ruff

> > @fruch Added more comments after looking at several python files. There are a lot of cases where transformation is ugly because the structure doesn't get changed. > >...