Florian Ritterhoff

Results 119 comments of Florian Ritterhoff

The Issue is not reproducible with 100% but it seems like that stopping the kafka container fails sometimes. On the next startup some "fragments" from the previous execution obviously cause...

Ah okay. Seems like, I figured out whats the problem. If you change anything on the kafka container, docker-compose recreates the container. That causes creating a new broker and this...

> > > Does this solve the Problem mentioned in #24. @fritterhoff Maybe it makes integrating the reverse proxy easier.

In detail the problem comes from: https://github.com/hm-seclab/YAFRA/blob/3e1f94748b06332db2762820ba587a99e319a03b/iocextractor/templates/index.html#L4 Here you reference the static resources directly without any prefix. We should at least change that to ```html ```

According to https://dlukes.github.io/flask-wsgi-url-prefix.html that should solve the problem in combination with the env var `SCRIPT_NAME`.

That has to be combined with #123 and causes some major changes in the internal API. Must be fixed manually.

> > Would you mind to write a short test for this change(s)? The existing tests should also be fixed. > > Hi, I looked into the failed tests. To...

Hi @cbergmann for the future: Please one single change in one PR ... (beside the large refactorig done by myself in #23) That makes tracing changes easier 😉 At the...

I just had some time to dig into the failing tests and yes, they break due to the format changes. ![image](https://github.com/eduMFA/eduMFA/assets/32478819/91b005ac-df99-4e4a-8a11-c4a277cefef5) From my point of view @pmainz is right and...