Frankie Roberto

Results 99 comments of Frankie Roberto

One of the questions for this component is what do we call the param that holds the array of things with statuses? Our initial instinct was to use `rows` to...

GDS wrote a summary back in 2017 of some of the [pros and cons of using Tables, Definition lists and Lists](https://github.com/alphagov/govuk-prototype-kit/pull/365#issuecomment-288417322).

We might want to add `role=list` to the ``, see https://github.com/alphagov/govuk-prototype-kit/issues/1009 cc: @edwardhorsford

Here’s the [original PR which added the task list to the Prototyping Kit](https://github.com/alphagov/govuk-prototype-kit/pull/361).

> One of the questions for this component is what do we call the param that holds the array of things with statuses? > [...] > Based on this, I...

@owenatgov many thanks for reviewing this! It is still work-in-progress, but now is definitely a good time for us to start to get detailed reviews and to refine the code.

@owenatgov thanks for the follow-up review! (Sorry it's take a while to respond, I was on holiday). And no worries about coming across snipey, these comments are great and I...

As @edwardhorsford points out, one of the issues when showing all after clicking when there's an existing selection is when do you go back into "filter" mode? When making any...

@timpaul might be worth adding that the Character Count component also has hardcoded English text (see [code](https://github.com/alphagov/govuk-frontend/blob/master/src/components/character-count/character-count.js#L175-L178)), and so whichever solution is proposed for translation can be adopted there too?

Here's the basic weighting algorithm I used in the govuk-government-organisations autocomplete (which has been used by a couple of different teams): https://github.com/frankieroberto/govuk-government-organisations-autocomplete/blob/master/src/govuk_government_organisations_autocomplete.js#L27-L83 The intention was to prioritise start-of-word matches (eg...