Frankie Roberto

Results 99 comments of Frankie Roberto

@paulrobertlloyd all good questions! The original intention was that the task list component wouldn’t use the tag component (as the design was so different) and so we just had a...

> Sidenote: wondering about the usefulness of the secondary text colour as an option – does it add anything? Would most users notice the difference? It’s intended only for use...

> * The Nunnucks options for the [Phase banner component](https://design-system.service.gov.uk/components/phase-banner/) shows this for its corresponding `tag` option: > > Options for the tag component. See [tag](https://design-system.service.gov.uk/components/tag/#options-tag-example). Ooh, I’d not spotted...

@colinrotherham @36degrees sorry for the delay (I was on holiday). This PR has now been rebased from the `release/5.0` branch, and I’ve fixed up a few minor things I spotted....

~~@colinrotherham can you think of any way to resolve the duplicate ID issue, caused by embedding the same example HTML twice in the page?~~

@owenatgov this is all green now, and so should be mergeable into the `release/5.0` branch if you could do a final review? One issue that came up when converting the...

@stevenjmesser I've added the `idPrefix` to all of the examples on the page in 7b758c219096d58021d70e30703efab2629a63ca – I think this is sufficient for now?

I like this! The implementation works how I'd expect it do, ie once you specify a `name` attribute, there’s no further work to do. Behind the scenes, the prototype kit...

One option is to have separate helpers for the form group and the label: ```erb Content More content ``` Another option is to add before_input and after_input options to the...