Frankie Roberto

Results 99 comments of Frankie Roberto

> I've also had times where I didn't need visually hidden text because the visible text was already descriptive and unique. Interesting! I'd assumed this was really rare (for summary...

@peteryates great - we could leave this PR open until we're ready for the next breaking change release? (Do we have any other breaking changes on the horizon?)

@peteryates @paulrobertlloyd should we follow the [draft govuk-frontend implementation](https://github.com/alphagov/govuk-design-system/pull/2251/files) and have this be an extra feature of the existing summary card component, rather than a standalone component? That would mean...

I'd agree that the nested hashes are a bit un-Rails like – and make it harder for code editors to assist with autocompletion, etc. One option could be to unnest...

I like this idea, but I think we should avoid using the word `external` in the helper method name or attributes, as the Design System doesn’t say to open external...

Looks good! Might be worth checking if this plays nicely if you were to also specify those `rel` and `target` attributes as options (even though this seems unlikely)? eg: ```ruby...

@36degrees ha, interesting, thanks! We wondered (on the cross-gov Design Systems chat) whether there was any history behind this, or the NHS version... 🤔

> As a suggestion, what if we only reactivated the full width on smaller screen sizes? It feels like at smaller sizes it would have the most benefit and at...

I did a quick review of other design systems (that I know of) and there's a fairly even mix of behaviours: Full-width labels: * [US government](https://designsystem.digital.gov/components/checkbox/) * [Transport for West...