Francisco Giordano
Francisco Giordano
>The abi could be fetched from the contract artifact that truffle generates, couldn't it? This library is not who should be doing that. The error needs to be decoded at...
Are yous ure this is happening in `expectRevert`? I don't see how this could be caused by test-helpers.
Can you submit a PR? We also need an integration test. You can look at #131 for reference.
I agree this would be very useful. I'm not sure what a nice API for it would look like. I wonder if we can do something similar to `balance.tracker`?
I edited the issue to make it more general than only fixing `expectEvent.inConstruction`.
Also, we don't really know yet if this will be feasible.
Yes this would be great. I don't know how we would implement it though. We rely on the error message that Truffle emits. What error message does Truffle emit on...
Thanks for looking into this. From a quick test Hardhat doesn't support Panic either, so I opened an issue there too. https://github.com/nomiclabs/hardhat/issues/1209
I think the bug would happen when one does: `expectEvent(receipt, 'MyEvent', { myNumber: '62224' })`. So when the argument is a string and not already converted to BN. We want...
I added the test that I thought would catch this but it succeeds on my computer. See https://github.com/frangio/openzeppelin-test-helpers/commit/671da752df8035e63e82109df60ed8558b27dc43.