Results 844 comments of Francisco Giordano

> Anyways this standard can be added now and replaced later with a better one. Unfortunately it's not so simple. Adding code to the library has real maintenance costs and...

@elawbek Hopefully nothing else. We will let you know otherwise. Thanks!

@bogdan's proposal is to use a globally shared contract for error string decoding so the storage cost would be paid once upfront and not by the user. While I sort...

Balancer's approach to remove revert strings from the code is to use numeric codes along with a helper to generate a revert string with the ASCII number at runtime ([`BalancerErrors.sol`](https://github.com/balancer-labs/balancer-v2-monorepo/blob/2e08c0a54dfb6c42e39c9b1b83de2e84f10b8be5/pkg/interfaces/contracts/solidity-utils/helpers/BalancerErrors.sol))...

Hi @lavalamp-, as per our [security policy](https://github.com/OpenZeppelin/openzeppelin-contracts/security/policy) we only commit to backporting critical security fixes, which none of these qualify as. Is the codebase in question actually affected by any...

Seems like the PR includes everything from `master`. Those are things we want to merge into `next-v5.0` because we need to keep it up to date but we should do...

@JulissaDantes Can you rebase on `next-v5.0`? Goal would be to remove these commits from the commit list: ![image](https://user-images.githubusercontent.com/481465/200052183-c70fe320-263f-477d-a083-de07705c6745.png)

I think I agree with your reasoning. However, this is a breaking change (removes internal availability of the function) so we will want to do it for 5.0.

Cool @Arachnid! We've always been reluctant to implement string utilities given that your library already existed :smile: so we're happy to see that you'd like to contribute it. There are...

Please allow for discussion first so we can understand if this is something we want in the library.