Francisco Giordano
Francisco Giordano
I'm personally not excited about this. We keep adding variants and having a lot of duplicate code. I'd like to see Solidity allow us to write these functions in a...
We should do the same with ERC20 and 1155.
There seems to be a Hardhat bug.
> Some types have been changed (for example from `IOwnable` to `address`. The change are marked by > `// OZ: retyped from xxx` Do we need these annotations for some...
This is in the `utils/constants` directory. Is that intentional? The category seems wrong to me.
This seems like something that should be added at the level of the Contracts for Cairo project, if `burnFrom` is seen as desirable (I am not sure that it is).
@Pandapip1 Can this be merged?
`clock` sounds good to me. Another alternative could be `tick`.
There is advanced work to do this in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3017. It's been delayed due to issues around interpretation of the spec. We'll get back to it as soon as priorities allow.
I've left [a comment](https://ethereum-magicians.org/t/eip4907-erc-721-user-and-expires-extension/8572/26?u=frangio) at Ethereum Magicians. At this point I don't think we should include this feature in OpenZeppelin Contracts due to unaddressed concerns and competing standards without a...