Fran Barton

Also change `address_details` to `addressdetails` but I haven't tested that. As documented at https://nominatim.org/release-docs/develop/api/Search/#parameters Compare: * https://nominatim.openstreetmap.org/search.php?q=halifax&limit=3&country_codes=gb,us _(result includes Halifax, Nova Scotia, which ought to be excluded: therefore this query...

Wish: base version of glue::glue()

3

It would be neat if there was a function in base that did something like ``` g("Hello, {user}!") ``` where `g()` provides the same functionality as `glue::glue()`. Strings with variable...

Internal: aim to reduce number of package dependencies from ~25 to <20

3

If possible.

Move "data origin" code into a data-raw folder

3

As suggested in the [R packages book](https://r-pkgs.org/data.html#sec-data-data-raw). Instead of under 'Working files'. Check all code still works to build datasets while we're at it.

Internal: Restructure ONS mortality data preparation workflow

1

Instead of multiple code sections for downloading CSV/XLS files that are then stored within the package directory, we should use functions that read in data directly from the URLs, process...

Would also require amending min R version in DESCRIPTION to: ``` Depends: R (>= 4.1.0) ``` ... although potentially not, if the base pipe is not in any user-facing functions...

- [x] Reproducible raw data import and cleaning script, with comments and context - [x] Cleaning script in `data-raw` folder as suggested by `{usethis}`/_"R Packages"_ - [x] Clean column names...

farver::decode_colour() could accept 3 character hex codes

1

3 character codes like `#9aa` are a useful shorthand, and are valid in HTML/CSS. Can farver be edited so as to accept these (and presumably convert them to the full...

internal: replace magrittr pipe with base pipe

2

If the dev team agrees with this then I can do the editing work to replace the pipes. It will require some changes to the way the mockery tests are...

Allow x_axis_date_format argument to ptd_create_ggplot() to accept a function not just a string

4

Currently [ptd_create_ggplot](https://github.com/nhs-r-community/NHSRplotthedots/blob/7dd037558b8edbe0d5eb3e663d7fcae62a1339f2/R/ptd_create_ggplot.R#L216) passes `x_axis_date_format` to the `date_labels` argument of `ggplot2::scale_x_datetime()`, which only accepts a format string. The `labels` argument of `ggplot2::scale_x_datetime()` will accept a function or a string (or a...