Florian Quirin

Results 316 comments of Florian Quirin

Hi @dpalou , that is unfortunately correct. I'll have to fix this sooner or later in my own app, but in the meantime you can use this: ``` cordova.plugins.notification.local.setDummyNotifications(); ```...

I'm currently hands deep in another project that I have to finish first. Maybe I'll find time to review the comments above and add a new permission request interface next...

Oh, I didn't notice that you can merge PRs here 😃, did @katzer hand it over to you?

@GitToTheHub I've done some smaller updates, mostly regarding the comments you've made. I did not touch the permission stuff yet, because the current implementation looks confusing and an improvement will...

@dpalou I'm assuming `PermissionHelper` is `org.apache.cordova.PermissionHelper` right? - Do we have to put an Android version check around it? - Should we use `PermissionHelper.hasPermission()` as well? - How do we...

I started from his branch, so I'm assuming all of this changes should be included in my PR. At least my branch says I'm not behind any of his changes.

I added a comment so we don't forget :-) and resolved the README conflict

Do you mean the commit from 'Jan 30, 2021'? I think that is just some branch merging, idk, but it seems to show no actual changes 🤔. All the 2020...

> Do you think the code from @dpalou could be helpful for you, to unify the requestPermission thing? I think so, the code looks pretty straight forward. Currently I'm more...