Filip Petkovski
Filip Petkovski
You can run `make lint` to fix the CI failure. I wonder if we want to add a small paragraph in the query docs that explains when to use which...
It seems to consistently fail on other PRs too, so it's unrelated to this change.
I bumped the CI and everything is green now. I'll leave some time for others to take a look before merging.
@yeya24 would you mind comparing the implementation to https://github.com/thanos-io/promql-engine/pull/550? This is the optimizer we already use in production and it has worked well for us so far.
It's production ready, we have extensive tests and over a year of production use in various places.
This change potentially modifies the contract with the scanner. I would like to test it with our downstream project this week before we merge it.
We added a new method to the interface, so we probably need to propagate that to all implementations.
> So, we have this then https://github.com/thanos-io/thanos/pull/8534, https://github.com/thanos-io/thanos/pull/8491. Is your PR solving the same problem(-s)? Could you help with reviewing those PRs? This PR resolves the problem where connections are...
Yes that was the idea. Ok let me rebase it and push another version.
Thank you @alamb. I am aware of the CI issues and plan to address them. I was hoping to first get feedback on the overall direction.