Filip Petkovski

Results 296 comments of Filip Petkovski

Does the issue happen only when metric name is not specified?

Ah sorry, missed that. Marked as done now ✅

@zeus2611 maybe you can look into adding support for the `absent` function? Start by adding a test case, and work your way to making the test case pass.

Since the function operator takes a slice of operands, do we need anything special for variadic functions? For the second point, I agree that we need a better way to...

I think we still need to add support outside of subqueries.

Hi @subhramit, it seems like holt_winders was indeed removed in Prometheus 3.0, so an implementation is no longer needed. We do need one for `double_exponential_smoothing` though, so you are welcome...

I would recommend that we do the mapping between different series IDs in the dedup checking operator. This way two series with the same ID would get mapped to a...

Hi @harsh-ps-2003, thank you for looking into this. Instead of a new operator, I would suggest adding a filtering function to the vector scanner which would take in a step...

I suggest that you add a new test case in [this test](https://github.com/thanos-io/promql-engine/blob/main/engine/engine_test.go#L99) and then we can see if your change works. Feel free to raise a PR with the new...