Filip Petkovski

Results 289 comments of Filip Petkovski

It looks like the PR has gone stale. Would you be interested in wrapping up the work?

/remove-lifecycle rotten

/remove-lifecycle stale

This approach looks good to me. I would just start with implementing namespace selection by label and then we can tackle selection by prefix in a subsequent iteration. I don't...

We can use the notation you originally suggested, but we can only implement watching namespaces by label in the first iteration.

Ah, okay, so the wildcard is essentially a prefix placeholder and the brackets contain the labels from the namespace. If it is easier for you do implement both prefixes and...

Thanks for the contribution. As discussed in one of the previous issues, I think this should be a new metric where the exit code is a value. Otherwise the cardinality...

This looks good, but the CI needs to be fixed before we can merge it.

You can check directly what the CI commands are. It seems that [`make test-benchmark-compare`](https://github.com/kubernetes/kube-state-metrics/runs/6873557351?check_suite_focus=true#step:5:2) and [`make doccheck`](https://github.com/kubernetes/kube-state-metrics/runs/6873557547?check_suite_focus=true#step:5:2) are failing.