Filip Petkovski

Results 296 comments of Filip Petkovski

How is this different from using `histogram_quantile(1, metric)` and `histogram_quantile(0, metric)`?

Thanks for the review. I extended the tests to include exact sample comparison between original and encoded samples and added assertions for the counter reset hint. Let me know if...

Please see https://github.com/thanos-io/thanos/issues/6942

This could be related to https://github.com/thanos-io/thanos/pull/6329. Do you know many blocks you have approximately in object storage?

I suggest we group all blocks by labels here https://github.com/thanos-io/thanos/blob/main/pkg/store/bucket.go#L873-L889 and return one `TSDBInfo` per stream rather than per block. @MichaHoffmann has noticed a trend of network usage going down...

Looks like unit tests are still failing.

@coleenquadros would you mind rebasing and we can merge this PR.

You can use the `/debug/pprof/goroutine` endpoint to see which goroutines are running when this happens.

I tend to agree that such metrics often provide little value and at the cost of increasing cardinality. The backwards incompatible change is a concern though, and I am not...

Sounds good to me, happy to have labels and annotations not exposed by default. I think a large majority of users would benefit from this change anyway.