Maksim Sinik

Results 97 comments of Maksim Sinik
trafficstars

Really a good call! +1 to this

@wdalmijn can you please fix the conflicts?

This is the case you are referring to: https://github.com/fox1t/modules-playground/blob/master/modules/ts-es-module-interop-false/cjs-namespace.ts As far as I can see there are no fail cases: `cjs-namespace` is always importable.

@Uzlopak, it is truly a complex task. GL & HF.

Super seeded by https://github.com/ducktors/turborepo-remote-cache/pull/86

This would be amazing. I need to take a deeper look into it, though.

I had the same issue and fixed adding `'vim'` to `ensure_installed.`. Maybe we should add 'vim' to that array by default. Are there drawbacks to adding it?

Yes, I observed the same about the onRequest not being called. Do you think we can call `instance.setNotFoundHandler` inside the `onRegister` hook to add a dummy handler? ref: https://github.com/fastify/fastify-express/blob/master/index.js#L83

This is enough to make it work: ```ts function onRegister (instance) { instance.setNotFoundHandler() const middlewares = instance[kMiddlewares].slice() instance[kMiddlewares] = [] instance.decorate('express', Express()) instance.express.disable('x-powered-by') instance.decorate('use', use) for (const middleware of middlewares)...