turborepo-remote-cache icon indicating copy to clipboard operation
turborepo-remote-cache copied to clipboard

Published 20 hours ago • verified publisher icon ducktors

feat | added support for AWS_SESSION_TOKEN

Open wdalmijn opened this issue 2 years ago • 2 comments

Description

This PR adds support for the AWS_SESSION_TOKEN variable, which is used when using shortlived AWS IAM credentials. The logic added will only add this variable if the value is defined, otherwise it will be skipped. This should hopefully not cause any issues for installations not using the sessionToken.

I did not find any tests related to connecting to AWS S3 so I wasn't able to improve test coverage; should I try and investigate how to test this particular feature or can I just leave the PR as is?

Docs

Implemented based on these SDK docs.

wdalmijn avatar Aug 10 '22 11:08 wdalmijn

Hej. Thanks for the PR. It would be nice to test this, but I am unaware too of how we do it. :/

fox1t avatar Sep 14 '22 08:09 fox1t

If I have some time in the next weeks I'll see if I can use nock / msw to test the requests the AWS SDK is making and verify the changes are applied.

wdalmijn avatar Oct 03 '22 21:10 wdalmijn

@wdalmijn can you please fix the conflicts?

fox1t avatar Nov 02 '22 10:11 fox1t

@all-contributors add @wdalmijn for code

matteovivona avatar Nov 03 '22 16:11 matteovivona

@tehKapa

I've put up a pull request to add @wdalmijn! :tada:

allcontributors[bot] avatar Nov 03 '22 16:11 allcontributors[bot]

@wdalmijn I resolved some conflicts, but I have a hunch that the new codebase differed too much from your feature. Could you please check? Also, please update the documentation that you can found here https://github.com/ducktors/turborepo-remote-cache/blob/main/docs/supported-storage-providers.md

matteovivona avatar Nov 16 '22 22:11 matteovivona

Super seeded by https://github.com/ducktors/turborepo-remote-cache/pull/86

fox1t avatar Dec 13 '22 09:12 fox1t