Maksim Sinik

Results 97 comments of Maksim Sinik
trafficstars

@cjkarande unfortunately, not yet! :(

Can you try to remove allowJS and run the tests again?

I looked into this and I am not sure what is going on. The main issue might be on the `FastifyPlugin` generic side. I'll look deeper into this ASAP. Thanks...

I agree with all of you, here. I agree with @lmammino that it is important to have a "marketing" vision of the pinned organizations since many developers tend to use...

I rally like your proposal!

I think that we need a definition of a "globally recognized brand" and it has to be clear. A couple of questions: 1. a brand that is recognizable in a...

What about the Boom approach: adding `isFastifyError` to the instances and a static method that checks if an object is a FastifyError instance? Reference: https://hapi.dev/module/boom/api/?v=10.0.0#isboomerr-statuscode

> Do not make it an `instanceof` check. Add a `Symbol.toStringTag` and check `Object.prototype.toString.call`. I am not sure how this plays out with my proposal. Is this an alternative approach?

Yes. That's why I don't want to use it either. I am firmly against the instanceof operator. I prefer Boom's approach for that reason. It is better to ship the...

Sorry for phrasing it badly. What I meant is to expose a function that will check our own known property. 👌