Fabian Meumertzheim

Results 1695 comments of Fabian Meumertzheim

It needs to pass through the Apple variables (mostly `DEVELOPER_DIR`) in a weird way because that's how GraalVM expects them. Is there a way to detect "if it wasn't using...

Since it's already asking a lot of rulesets to use `apple_support` for Xcode support on macOS, I think that this logic should ideally live in `apple_support.run`.

@hvadehra I think that we need to have a new java_tools and rules_java release + bump in `bazel_tools` dependencies for this to be considered "done".

@Wyverald This is stacked on #21901, but otherwise ready for a first review.

I rebased and fixed the remaining tests. This got a bit larger as I reverted some commits instead of adapting their code and removing it in a follow-up PR, but...

The RBE run of `starlark_repository_test` keeps failing with connection timeouts, but I don't think that's something I could do anything about.

Forgot to update the test lockfile, hope this is green now.

@Wyverald The `--batch` tests in `starlark_repository_test` appear to time out pretty reliably. Do you know whether `--batch` messes with repo cache or lockfile usage in any way? I'm not sure...

I noticed that this patch causes the `verify_default_lockfile` test to fail, which I wouldn't expect if the test repo cache is populated correctly (with the new lockfile format): ```diff diff...