Fabian Meumertzheim

Results 1695 comments of Fabian Meumertzheim

@justinhorvitz Could you review this? I sent my previous work on option parsing to you, but feel free to reroute.

@ivan-golub How many CPUs do you have on your machine? And how many repos are there that could potentially be fetched in parallel? My suspicion: Loom doesn't use non-blocking file...

@ivan-golub @jfirebaugh Could you share at least a rough breakdown of which rulesets/repo rules contribute to this number of external repos?

I tried to reproduce this for a while, both on synthetic and real-world projects, but I haven't observed any meaningful difference between 7.0.2 and 7.1.2. `--loading_phase_threads` is being honored in...

I found a clean reproducer on Slack (thanks @hugocarr): https://github.com/hugocarr/cloud_repro/tree/hugo/requirements_oom I get an OOM with `--loading_phase_threads=4` that I don't get with `--loading_phase_threads=4 --experimental_worker_for_repo_fetching=off`. The profiles show that with `off`, there...

Good news: I tested the repro with 7.2.0rc3 and it seems that the issue is fixed there. I don't know why though. [profile.rc3.json](https://github.com/user-attachments/files/15737477/profile.rc3.json)

I checked that this isn't fixed by #21622. Since it also relies on `--noenable_bzlmod`, it's unlikely to be related to repo names. CC @oquenchil

Note to self: Make buildozer aware of this too when accepted.