Fabian Meumertzheim
Fabian Meumertzheim
@comius Friendly ping
> The problem is that once you have `native.repo_name` you can implement `native.package_relative_label`. I see your point, just want to remark that this is not possible: `native.package_relative_label` crucially applies the...
@comius I special cased the setup for `native.package_relative_label` by just providing the `LabelConverter` as a thread local, thus getting rid of the new phase. PTAL, this is much simpler now.
@comius Friendly ping
@bazel-io fork 7.2.0
@comius @iancha1992 Friendly ping, is this still on track for merging?
@iancha1992 Done
I think that there are valid use cases for having features mentioned in BUILD files and command lines that aren't available on the toolchain (say `layering_check` on Windows). That said,...
@comius What about the case of `--features=feature1,feature2` though? Arguably `--features` should be called `--feature`, but as long as it isn't, this particular pattern is very errorprone.
That does sound right. Directory expansion is even enabled by default.