Fabian Meumertzheim

Results 1684 comments of Fabian Meumertzheim

Thanks for the contribution, I will take a look. You can create proper integration tests using `go_bazel_test`, see https://github.com/bazelbuild/rules_go/blob/master/tests/core/go_binary/non_executable_test.go for an example. In this way, you can set environment variables,...

@achew22 What do you think, could we temporarily include this without test coverage until we raise the minimum to 5.3.0?

> I tried adding an explicit version check, assuming `native.bazel_version` would work, but turns out this is only available for workspace macros? [bazelbuild/bazel#8305](https://github.com/bazelbuild/bazel/issues/8305). Is there a better way to check...

@linzhp Now that we are on 5.1.0, do you think we can go up to 5.2.0 in the next release? That would greatly simplify this PR.

@ttpathan Sorry for the back and forth (and delay), but we are finally ready to update to 5.2.0. Instead of the version check, you can just use `inherited_environment` unconditionally and...

@KyleWiering Sorry that I missed this earlier, but [`docs/go/core/rules.md`](https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/rules.md) is actually generated from [`docs/go/core/rules.bzl`](https://github.com/bazelbuild/rules_go/blob/master/docs/go/core/rules.md) and, in the case of your changes, [`test.bzl`](https://github.com/bazelbuild/rules_go/blob/31d17212968b472032035a45353a1751f1c0f529/go/private/rules/test.bzl#L243). Could you copy your changes into these places...

@mancusi Does this also fail with the other modes (`"archive"`, `"link"`) set on `go_path`? If Go itself uses embeds but can't embed symlinks, then some modes of `go_path` will probably...

If you use CGo, both vanilla Go and rules_go will pick up local libraries - without further setup, there simply isn't anything else to use to satisfy the libc requirement....

@achew22 @linzhp I think we should just do the same as Bazel does with its remote JDKs: Define toolchains for all architectures that reference the actual SDKs via an alias...