Fabian Meumertzheim
Fabian Meumertzheim
> Can we add a test case for valid purls that Bazel will reject (e.g., `pkg:bazel/Curl@1234`) to have coverage for the non-validation case? Added via b29e1ea420b4e3ffc7f5b331e0fbe8aae2da6cfe
@pombredanne PTAL
@jkowalleck Friendly ping, what is needed to get this merged?
@pombredanne Friendly ping
@mjherzog Could you take a look?
Could you check whether https://github.com/bazel-contrib/rules_go/commit/66cd5f5ea009cfe349de526772a7e877cdd76d34 fixes this?
If you provide me with a small Git repo and setup instructions that reproduce the issue, I would work on a fix.
Thanks for the investigation, that sounds exactly right. It seems like you know pretty well what would need fixing - would you consider working on a PR for this? I...
A small Go program that generates the JSON sounds reasonable. In that case you should be able to use `ctx.actions.run` instead of `ctx.actions.run_shell`. `GoFiles` and `CompiledGoFiles` only differ when code...
@tyler-french @linzhp Just brainstorming: * We may want to drop `goos/goarch` and `go_cross_binary` in favor of more generic approaches such as rule extensions and `with_cfg.bzl`. * We need to revisit...