Fabian Meumertzheim

Results 1692 comments of Fabian Meumertzheim

@tjgq I found these bugs while working on the output inlining feature for remote execution.

Tests are passing again, I forgot to use the `reencode` method in one spot.

There are some non-serialization usages of Unsafe for optimized String access, but those can easily be migrated to `VarHandle`.

I resolved the conflict and subsequently fixed the existing tests after the merge of the `SymlinkAction` PR.

While adding more tests, I noticed that there is a pathological case that the new representation currently doesn't handle: If multiple artifacts at canonical locations collide, then the last in...

@tjgq I added a bunch of tests and addressed your comments. Since we were already making breaking changes to the format, I slightly tweaked how we represent IDs also in...

Could you try adding `.git` to `.bazelignore`?

I would like to get rid of `workspace_root` as well, with a suitably named replacement. Otherwise we would still have mentions of `workspace` stick around that would require another flag...

I would say `repo_root` or `repo_path`. I would prefer the latter as `File#root` returns a special starlark type, not a string.