Fabian Meumertzheim comments

Results 1694 comments of


                                            Fabian Meumertzheim

feat: cross-compile to windows msvc

I generally like this a lot and can review when you think it's ready. We should strive to make the change in a way that somewhat obviously doesn't change command...

Optimize `copy_file`

FYI @kormide, I think that most of the exec requirements are actually harmful for `copy_file`. Do you see any downside to dropping them as long as they are kept on...

> I wonder if it would be helpful to have a mechanism to pass in `execution_requirements` manually? You mean on a per-target level (per-mnemonic level is possible with `--modify_execution_info`)? I...

fix(gopackagesdriver): Improve wildcard package query matching

What does the actual kind look like in that case that it doesn't match the start of string?

fix(gopackagesdriver): Improve wildcard package query matching

Thanks, I thought this also affected the usage of `^` in the `kind` part of the query, but it doesn't.

Fails on Bazel's CI for Bazel >= 7.3 on Windows

Thanks for catching this. Could you file an issue on the Bazel repo? This needs a fix and probably also a point release. I'll dig into why it happens.

go.mod FilePath ReplaceDirective fails copying folder.

It seems reasonable to skip all top-level directories that start with a `.`. Would you be interested in sending a PR?

go.mod FilePath ReplaceDirective fails copying folder.

Ah, that makes sense. Then let's try to fix symlinks instead :-)

Return, don't fail, when extension used by non-root module

I see two separate threads here: 1. Having one "official" way of using `toolchains_llvm` in a module that is also meant to be used by other modules. 2. Supporting transitive...