Florian Lehner
Florian Lehner
> It looks like auparse.AuditMessage could also be reordered. Do you want to fix that one too? done :white_check_mark:
Looking at the current top 10 functions of `auditbeat` from Elastic Cloud QA, these small changes will make a difference:  As I'm not allowed to (test-)deploy...
The problem I see with the posted benchmark is, that is focusing purely on the written benchmark. And there the changes are marginal. There are way more allocations happening in...
friendly ping @andrewkroh && @efd6
friendly ping @andrewkroh && @efd6
friendly ping @andrewkroh && @efd6 && @adriansr
friendly ping @andrewkroh && @efd6 && @adriansr
As https://github.com/elastic/go-libaudit/pull/117 is neither approved nor merged, this change should report at least some unaligned structs. Also for `auditRuleData` I would expect a `nolint` instruction, as fieldalignment is not happy...
There is an open proposal for Go to support types like `uint128` in https://github.com/golang/go/issues/9455. But so far native Go doesn't support `uint128`. Was an external package used that tries to...
Checked reported linting errors. They are not related to the proposed changes in this PR.